Fix affected target computation breaking CI workflows when no targets are affected #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
(Note that this is effectively in 'draft' mode but can't actually be marked as draft since we need to run CI for investigation here). |
BenHenning
changed the title
While Bazel can run an empty list of tests, GitHub actions always expects at least 1 entry for matrix-dependent actions. This is based on https://github.community/t/empty-matrix-fails-workflow/128736/2. It's not yet clear if this will properly allow check_test_results to pass if the workflow is skipped. That will need to be tested.
|
https://github.community/t/empty-matrix-fails-workflow/128736/2 seems like a viable fix. |
|
Now that #2710 is merged restarting these workflows to see if I fixed the issue. |
…ithub.com:oppia/oppia-android into fix-incorrect-affected-target-handling-when-empty
|
Yay, looks like this solution works. However, it does cause the check test results action to fail. :( I was partly expecting that to happen. I guess we need to also need to condition the steps of that task or something. Need to think on it a bit more. |
|
Awesome, it's passing now. Reenabling other tests & sending this out for review. |
Reenable jobs.
Undo removing the newline since it's not actually needed.
BenHenning
changed the title
I forgot that we're performing an empty check, so the extra newline does break it.
anandwana001
approved these changes
Feb 13, 2021
BenHenning
deleted the
fix-incorrect-affected-target-handling-when-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2691 (comment) & https://github.com/oppia/oppia-android/actions/runs/560112155 for context. It seems when there are no affected targets an empty line will be printed which breaks something between the jobs. I think this will fix it.
Conveniently, this PR should trigger the "no affected targets" workflow & can self-verify itself.